Skip to content

Revert routing for longer review - #4953

Merged
tephenavies merged 1 commit into
nextfrom
next-without-routing
Nov 2, 2020
Merged

tephenavies merged 1 commit into
nextfrom
next-without-routing

Conversation

@tephenavies

@tephenavies tephenavies commented Nov 2, 2020 •

Copy link
Copy Markdown
Contributor

What this PR does

Revert routing PR to fix CI & relative URL issues. We should put the routing changes through a longer review process to consider all of the impacts of those changes.

Checklist

  • Fix up changelog

@tephenavies
tephenavies marked this pull request as draft November 2, 2020 07:26
@nf-s
nf-s marked this pull request as ready for review November 2, 2020 07:39
@nf-s
nf-s marked this pull request as draft November 2, 2020 07:39
@nf-s

nf-s commented Nov 2, 2020 •

Copy link
Copy Markdown
Contributor

#4679 has broken quite a few things:

I think #4679 and the TerriaMap PR (TerriaJS/TerriaMap#500) should be reverted, it needs more to be more thought out and more thoroughly tested.

@tephenavies
tephenavies marked this pull request as ready for review November 2, 2020 17:14
@tephenavies
tephenavies merged commit f4fe151 into next Nov 2, 2020
@tephenavies
tephenavies deleted the next-without-routing branch November 2, 2020 17:14
@soyarsauce soyarsauce mentioned this pull request Nov 4, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants