Skip to content

Fix macOS Alt+digit characters in SSH terminals - #1398

Open
ZacharyZcR wants to merge 1 commit into
Termix-SSH:dev-2.8.0from
ZacharyZcR:fix/support-1262-macos-alt-digit
Open

Fix macOS Alt+digit characters in SSH terminals#1398
ZacharyZcR wants to merge 1 commit into
Termix-SSH:dev-2.8.0from
ZacharyZcR:fix/support-1262-macos-alt-digit

Conversation

@ZacharyZcR

Copy link
Copy Markdown
Member

Summary

  • only route Alt+1..9 to tab shortcuts when the logical key is the matching digit
  • preserve keyboard-layout characters such as macOS Option+7 (|) in SSH terminals
  • add regression coverage for both the shortcut and layout-character paths

Verification

  • pnpm vitest run src/ui/tests/lib/app-keyboard-shortcuts.test.ts
  • pnpm eslint src/ui/lib/app-keyboard-shortcuts.ts src/ui/AppShell.tsx src/ui/features/terminal/Terminal.tsx src/ui/tests/lib/app-keyboard-shortcuts.test.ts
  • pnpm tsc -b --force

Fixes Termix-SSH/Support#1262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant