Support line ending options

[SinghRajenM]

No description provided.

[tencent-adm]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[miloyip]

I think this can be done in output stream instead.
Also, standard file i/o stream should already have conversion.

[SinghRajenM]

I think this can be done in output stream instead. Also, standard file i/o stream should already have conversion.

I am not pretty much sure about it.

But we are using StringBuffer to get prettier string. Something like below -

    rj::StringBuffer                                                                                      sb;
    rj::PrettyWriter<rj::StringBuffer, rj::UTF8<>, rj::UTF8<>, rj::CrtAllocator, rj::kWriteNanAndInfFlag> handler(sb);
    handler.SetLineEnding(le);
    handler.SetFormatOptions(lf);
    handler.SetIndent(indentChar, indentLen);
    
    rj::Reader       reader;
    rj::StringStream ss(jsonText.c_str());
    success = reader.Parse<someflags>(ss, handler) && sb.GetString();

Here, we are expecting that sb.GetString should provide pretty json with desired line ending option.

[SinghRajenM]

@miloyip Is there anything needed from my end to get this accepted and merged?

[miloyip]

Hi. As mentioned previously, πdon't think this should be implemented at this level of abstraction. For example, if you write to string, and then output it as a file, it should do the conversion at file writing part, which is accomplished by lower level APIs.

[SinghRajenM]

Hi @miloyip,

I didn't fully understand your comment. However, what makes you think that PrettyWriter (here and other places assumes the line ending should be \n)?

rapidjson/include/rapidjson/prettywriter.h

Lines 145 to 148 in 24b5e7a

	if (!empty) {
	Base::os_->Put('\n');
	WriteIndent();
	}

That said, I'll leave it up to you to accept or reject the solution. I've been using this approach for a long time in one of my other projects, and it has been working well. Please note that this change does not alter the default behavior—the line ending remains \n unless explicitly specified. The only issue I face is that whenever I update the RapidJSON submodule, I have to manually ensure that this change persists after fetching the latest version. Hence, this proposal.