fix(train): replay epochs after prevalidation rollback - #273
Merged
Conversation
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an epoch-end callback makes the online model non-finite,
_recover_before_validation()restores the healthy checkpoint but returns false. Validation then succeeds on restored weights, so the rolled-back attempt is logged as a completed epoch, the recovery counter is cleared, and the MoE scheduler receivesrecovered=False. A repeated fault can therefore silently discard each epoch without exhausting the retry limit.Return the replay signal after an online rollback, reset gradient accumulation before replay, and finalize that attempt with
recovered=True, validated=False. EMA-only resynchronization keeps its existing behavior. Adjust the existing online/EMA test to inject once; add offline real-training regression cases for one-time and persistent faults, checking optimizer updates, validation calls, CSV rows, scheduler flags and the recovery budget.Validation:
This fixes prevalidation rollback accounting; it does not prevent the original source of non-finite values.