fix(model-zoo): validate each redirect before following - #270
Merged
Conversation
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model-zoo downloader validates only the final hostname after urllib has followed redirects. Apply the existing HTTPS/host policy before every redirect request, as well as before the initial request, and reject alternate ports and embedded credentials. Keep final-URL, declared-size and SHA256 checks.
Validation: 7 regression cases passed on this independent branch. Offline tests reject HTTP downgrade, non-allowlisted destinations, alternate ports and credentials before returning a redirect Request, accept the normal HTTPS release-asset path, verify use of the checked opener, and retain digest validation. Tests pass Ruff lint/format; production critical-error lint and git diff --check pass. No live exploit or external network probe was performed. Repository-wide lint/format have existing findings and codespell is unavailable.
Based directly on main b44ea12; limited to the downloader and its tests.