Repository navigation
fix(yuque): discard canceled sync results - #5493
Open
OUAO-FRANK wants to merge 1 commit into
Open
OUAO-FRANK wants to merge 1 commit into
OUAO-FRANK wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cancellation during the last detail request can be handled as a per-document fetch error. With no more requests to make, the connector then returns a batch and a new cursor as if the sync succeeded.
Check the context at the return boundary and discard the batch and cursor when canceled. Ordinary per-document failures retain the existing retry behavior.
Type of Change
Related Issue
Fixes #5491
Testing
The local HTTP regression failed three times on main and passed three times with the patch. Linux Yuque package tests, go vet, diff-scoped golangci-lint, server build and git diff --check passed.
Checklist
AI assistance: Codex diagnosed the issue, implemented the patch and ran local checks.