fix(domain): fail-closed passenger residual via Cat 33 + THB (#150) - #166
Merged
telivity-otaip merged 6 commits intoAug 24, 2026
Merged
Conversation
Document passenger residual as Cat 33 + Historical Ticket Based (THB) valuation; reject original−used, original−change-fee, coupon-ratio, haversine, and MPA-P (interline-only). Agents 5.1/5.2/6.1 require an explicit method and return DOMAIN_INPUT_REQUIRED when unspecified. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Correct invented “Historical Ticket Based” expansion — THB is the IATA Ticketing Handbook (cite by name only). Rename residual method to PUBLISHED_FARE. Align with #153: no Cat 33 / unmatched provision → free penalty; bare waiver_code and missing proration method ≠ free (fail closed). Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 24, 2026 08:20
Rebase PR #166 onto latest main (waiver typology #153, US DOT 24h, tax carryforward, BSP HOT, ADM prevention, etc.) while preserving issue #150 domain rules: - Passenger residual = PUBLISHED_FARE | CARRIER_SPECIFIC (THB cite-by-name) - Fail-closed without proration method; no coupon-ratio / MPA-P / haversine - Waiver typology from main: assertChangeWaiverInput / assertRefundWaiverInput - Exchange-reissue keeps per-tax carryforward + requires residual_method All 3587 tests pass. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
…egration) Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
deleted the
cursor/partial-refund-residual-proration-29b1
branch
August 24, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150. Encodes the passenger residual / partial-refund decision tree: Cat 33 + IATA Ticketing Handbook (THB), not MPA-P interline proration, and fail-closed when the valuation method is unspecified.
What changed (latest)
main— PR wasmergeable_state: dirty; now integrates waiver typology (fix(agents): fail-closed Cat 31/33 waiver typology (#138) #153), US DOT 24h, per-tax carryforward, BSP HOT, ADM prevention, etc. without dropping [Help wanted] Partial refund / residual value: published-fare proration vs invented arithmetic #150 rules.PUBLISHED_FARE|CARRIER_SPECIFIC|FULLY_UNUSED(neveroriginal − change fee, coupon-ratio, MPA-P, or haversine).waiver_codewithoutwaiver_effect→ fail-closed viaassert*WaiverInput.Agents
residual_valuationrequired; waiver typology + US DOT 24h from mainresidual_method; keeps per-tax carryforward from mainPARTIALrequirespartial_valuation; waiver typology from main; no coupon-ratio prorationKB
docs/knowledge-base/partial-refund-residual-value.md— decision tree, worked examples, forbidden formulasTest plan