feat(adm-prevention): complete passive / UC / churning detection (#145) - #162
Merged
Merged
Conversation
Add KB-backed host status matrix (HX/UC/UN/NO/TK + extended), history-required churning, Travelport DX marriage note, and TTL deadline-day timezone checks. Fixtures encode scariest false negatives. No carrier-secret commission tables. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Do not globalize host-specific status codes as one IATA meaning. Core HX/UC/UN/NO/TK stays cross-host; HN/PK/GK/YK and peers apply only when gds is set. Unknown host uses core only (DOMAIN_QUESTION). Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 24, 2026 09:10
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145
What does this PR do?
Hardens Agent 6.2 ADM Prevention with KB-backed passive/UC/churning detection from mid-office practice, so HX/UN/NO-only scanners stop missing the scariest false negatives.
Type of change
Domain impact
Per authoritative KB for #145:
gdsis omitted/UNKNOWNHKalone is the classic false negativeKB:
docs/knowledge-base/adm-prevention.mdChecklist
pnpm exec vitest run packages/agents/settlement/src/adm-preventionpasses (62 tests)pnpm --filter @otaip/agents-settlement run typecheckpassesanytypesTest plan
gds=AMADEUS, Sabre YK only whengds=SABRE, no universalization of HN/PK/GK/YK without host, Travelport “no ticketing field” note, history-required churn, Travelport DX marriage break, TTL deadline-day timezone__tests__/fixtures/:churn-all-hk-now.jsonuncleared-tk.jsonuc-hn-passive-pk.json(Amadeus)travelport-dx-marriage.jsonttl-deadline-day-tz.json