feat(pricing/2.2): Fare construction hardening — IROE, TPM, 024d (#151) - #159
Merged
telivity-otaip merged 6 commits intoAug 24, 2026
Merged
Conversation
Hardens Agent 2.2 for #151: licensed data via data_sources, no bundled IROE/TPM files, bans on haversine-as-TPM and banker rounding, DomainInputRequired when IROE/TPM/024d missing. Adds KB data-dependencies doc and tests. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 24, 2026 08:40
CI gen:manifest --check failed after Agent 2.2 version bump. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Merge left docs/agent-map.html stale vs FareConstruction 0.2.0 + main agent docs. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Simple conflict in docs/agent-map.html — regenerated manifest to combine FareConstruction 0.2.0 (IROE/TPM/024d) with main's 5.3 IRROP/EU261 updates. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #151.
Hardens Agent 2.2 Fare Construction to fail closed on missing licensed data and documents the IROE / TPM / Resolution 024d (HX/NX) contracts — without committing proprietary IATA tables.
Domain correction (review): tax/payment FX is ICER, not IROE. IROE is fare construction only (Res 024c). Agent 2.3 must not consume IROE. Source: IATA Exchange Rates.
Type of change
Checklist
pnpm --filter @otaip/agents-pricing typecheckpassesanytypes without justificationdecimal.jsDomain impact
data_sources.iroe. No hardcoded rates; missing currency →DomainInputRequired.data_sources.mileage. Missing pair → fail closed; haversine banned (TPM Manual).data_sources.rounding_024d. No banker rounding.missing_inputs.Test plan
pnpm exec vitest run packages/agents/pricing/src/fare-construction— 24 passedpnpm exec vitest run packages/agents/pricing— 147 passedpnpm --filter @otaip/agents-pricing typecheckKB
docs/knowledge-base/fare-construction-data-dependencies.md— IROE (024c) vs ICER split, TPM, 024d, licensed-source notes, HIP/BHC/CTM sketch.