Fix crash when rotating modify bookmark dialog#4644
Open
geoffreysisco wants to merge 1 commit into
Open
Conversation
Migrate RenameBookmark from the platform DialogFragment implementation to AndroidX DialogFragment and update the launch path to use getSupportFragmentManager(). After the migration, the dialog restores successfully after rotation and bookmark functionality continues to work as expected.
geoffreysisco
changed the title
VishnuSanal
added
the
PR-Awaiting-Initial-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate RenameBookmark to AndroidX DialogFragment and update the launch path to use
getSupportFragmentManager().This fixes a crash that could occur when the device is rotated while the Modify Bookmark dialog is open. After the migration, the dialog restores successfully after rotation and bookmark functionality continues to work as expected.
Issue tracker
Fixes #4433
Automatic tests
Manual tests
Verified manually:
Attached video demonstrates:
after.mp4
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code