gui: keep storage selection on the mount page - #24
Open
sorrow404Null wants to merge 1 commit into
Open
Conversation
Place the storage selector before the conditional decryption control so it remains available when the encryption state changes. Test: xmllint --noout gui/theme/common/portrait.xml
There was a problem hiding this comment.
Pull request overview
This PR adjusts the TWRP GUI “Mount” page layout so the Select Storage control remains accessible regardless of whether the Decrypt Data button is currently shown (i.e., as encryption state changes).
Changes:
- Moves the Select Storage button earlier in the mount page’s element order (before the conditional decryption control).
- Keeps the button’s existing actions (
tw_back=mount+overlay select_storage) unchanged.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the storage selector before the conditional decryption control so it remains available when the encryption state changes.
Testing
xmllint --noout gui/theme/common/portrait.xml