Handle play-external IPC messages - #496
Open
DavidAGInnovation wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle
play-externalIPC messages in the v5 shell by routing them through the same native external-URL handler asopen-external.Problem
The web UI emits
play-externalwhen a non-HTTP external-player link is selected, but the shell only dispatchesopen-external. The UI then shows “Stream opened in external player” even though no player launches.Fix
Accept both IPC command names and call
Qt.openUrlExternally(args[1])for either one.This restores external-player launching for macOS and preserves compatibility with callers using
open-external.Related: Stremio/stremio-bugs#1743
Validation
git diff --check