Skip to content

Interactive account picker menu with dev+deploy commands - #39

Merged
Macil merged 4 commits into
masterfrom
chris/accountPicker
Aug 25, 2026
Merged

Interactive account picker menu with dev+deploy commands#39
Macil merged 4 commits into
masterfrom
chris/accountPicker

Conversation

@Macil

@Macil Macil commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR replaces account-registration links in deploy and dev with an interactive picker that can associate an existing compatible account, open a scope-upgrade flow, or start new-account setup. Reviewers should focus on the picker’s asynchronous recovery behavior and its integration with deployment polling and Ink lifecycle.

  • Adds a typed backend operation for associating an account with a deployment and includes compatible-account changes in deployment equality checks.
  • Introduces an @inkjs/ui Select shared by deploy and dev, with account filtering, display labels, setup-link launching, and association status/error rendering.
  • Makes deploy UI unmounting await Ink shutdown and distinguishes programmatic unmounts from user-triggered exits.
  • Updates Deno dependency metadata for the new terminal selection component.

Confidence Score: 3/5

The PR should not merge until both account-picker failure paths allow users to retry setup and association actions.

Browser-launch errors permanently disable the picker, while failed association requests silently suppress retries of the same account, leaving pending deployments blocked or requiring a command restart.

Files Needing Attention: ui/common.tsx

Important Files Changed

Filename Overview
ui/common.tsx Adds the shared interactive account picker, but both browser-launch and association failures can leave users unable to retry the intended action.
backend.ts Adds the authenticated account-association request and makes deployment polling observe compatible-account changes.
commands/deploy.ts Awaits Ink unmount completion and exits only when the renderer shuts itself down.
ui/deploy.tsx Mounts the account picker beneath deployment progress while registration authentication is pending.
ui/dev.tsx Mounts the same picker in the development deployment-readiness screen.
deno.json Adds the Ink UI package used by the new Select component.
deno.lock Locks @inkjs/ui and its transitive terminal-rendering dependencies.

Reviews (1): Last reviewed commit: "put padding above account picker" | Re-trigger Greptile

Comment thread ui/common.tsx
Comment thread ui/common.tsx
@Macil
Macil merged commit 36016cd into master Aug 25, 2026
2 checks passed
@Macil
Macil deleted the chris/accountPicker branch August 25, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant