Adjust Gateway unit build times after Warpgate Research#67
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the StarCraft II 5.0.16 change where completing WarpGate Research reduces Gateway-trained unit build times by 40% when back-calculating build-order start frames from tracker events.
Changes:
- Track each player’s
WarpGateResearchcompletion frame fromUpgradeCompleteEvent. - Adjust
adjust_build_time()to apply a 0.6x build-time factor for Gateway units produced after Warpgate completes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+748
to
+754
| # Warpgate Research speeds up Gateway unit production by 40% | ||
| if player in self.warpgate_research_frame and \ | ||
| 'Gateway' in cur_build_data.get('built_from', []): | ||
| warpgate_frame = self.warpgate_research_frame[player] | ||
| reduced_start = frame - build_time * 0.6 | ||
| if reduced_start >= warpgate_frame: | ||
| build_time = build_time * 0.6 |
Comment on lines
+749
to
+754
| if player in self.warpgate_research_frame and \ | ||
| 'Gateway' in cur_build_data.get('built_from', []): | ||
| warpgate_frame = self.warpgate_research_frame[player] | ||
| reduced_start = frame - build_time * 0.6 | ||
| if reduced_start >= warpgate_frame: | ||
| build_time = build_time * 0.6 |
Warpgate Research now speeds up Gateway unit production by 40%. Track when each player completes WarpGateResearch, then apply the reduced build time when back-calculating unit start frames. Uses a conservative check for the edge case where a unit starts building around the time research completes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gate the 40% Gateway unit speedup to build >= 97364 (patch 5.0.16+) so older replays are not affected. Add a replay and golden JSON test for the new patch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
StoicLoofah
force-pushed
the
warpgate-research-build-time
branch
from
38c9be7 to
e924605
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://news.blizzard.com/en-us/article/24259080/starcraft-ii-5-0-16-patch-notes
Summary
WarpGateResearchupgrade event frame)Test plan
🤖 Generated with Claude Code