chore(docs): updated comments and security around membership state/consensus#194
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xRigel-squads
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request clarifies and documents the independent authorization model for Spending Limits in the Squads Protocol. It emphasizes that Spending Limit permissions are managed separately from multisig membership, and changes to one do not automatically affect the other. The documentation is updated throughout the codebase and the security policy to make this distinction explicit.
Documentation and Protocol Invariants:
SECURITY.md, specifying that independent authorization for Spending Limits is an intentional property of the protocol, and clarifying that such behaviors are not security vulnerabilities.Spending Limit Membership Independence:
SpendingLimit,MultisigAddSpendingLimitArgs, andConfigActionto clarify that Spending Limit members are managed independently of multisig members, and changes to multisig membership do not implicitly grant or revoke Spending Limit access. [1] [2] [3]multisig_remove_memberinMultisigConfigto state that removing a multisig member does not revoke their Spending Limit access, which must be managed separately.