fix(cli): resolve SpendingLimit details on RemoveSpendingLimit display (MUL-754 / V4-19)#188
Open
bguillaumat-squads wants to merge 1 commit into
Conversation
MUL-754 (V4-19): display-config-transaction rendered RemoveSpendingLimit as only an opaque PDA, hiding which delegated spend authority is being revoked. Resolve the referenced SpendingLimit account and print its vault, mint, amount, period, members, and destinations, with an explicit warning when the lookup or deserialization fails. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Cantina finding V4-19 (Linear MUL-754).
display-config-transactionrenderedRemoveSpendingLimitas only an opaque PDA, so reviewers could not see which delegated spend authority was being revoked and could approve the wrong removal while a broader limit stayed live.Change
SpendingLimitaccount (via the existingget_spending_limitSDK helper) and print its vault index, mint, amount, period, members, and destinations.Scope:
cli/src/command/display_config_transaction.rsonly. Builds clean (cargo build -p squads-multisig-cli).Closes MUL-754
🤖 Generated with Claude Code