fix(sdk): pass the programId for non-standard deployments#186
Open
sean-sqds wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sean-sqds
marked this pull request as ready for review
June 9, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a critical issue with the
batchExecuteTransactionfunction in the multisig SDK, ensuring that customprogramIds are correctly forwarded when deriving ephemeral signer PDAs. This prevents unsignable transactions when deploying to non-default program IDs. The changes also add a comprehensive regression test to verify the fix.Bug fix for custom programId handling:
batchExecuteTransactioninbatchExecuteTransaction.tsto forward theprogramIdwhen deriving ephemeral signer PDAs, ensuring correct address derivation and preventing unsignable transactions on non-default deployments.Testing and regression coverage:
batch-sol-transfer.tsto verify that batch transactions with ephemeral signers work correctly under a customprogramId, preventing regressions of this issue (MUL-744).