Skip to content

"Allow" for 3D channel locations for compute unit locs and template metrics#4572

Merged
alejoe91 merged 7 commits intoSpikeInterface:mainfrom
chrishalcrow:improve-support-for-3D-locations
May 6, 2026
Merged

"Allow" for 3D channel locations for compute unit locs and template metrics#4572
alejoe91 merged 7 commits intoSpikeInterface:mainfrom
chrishalcrow:improve-support-for-3D-locations

Conversation

@chrishalcrow
Copy link
Copy Markdown
Member

@chrishalcrow chrishalcrow commented Apr 30, 2026

This PR allows for unit locations and template metrics to be computed when you have 3D channel locations (as is often the case with openly available data on DANDI).

It doesn't actually do anything, except slice the 3D locations into 2D. When we do this for the template metrics computation, a warning comes up.

@chrishalcrow chrishalcrow added bug Something isn't working postprocessing Related to postprocessing module labels Apr 30, 2026
@chrishalcrow chrishalcrow marked this pull request as ready for review May 1, 2026 14:54
@chrishalcrow chrishalcrow requested a review from samuelgarcia May 1, 2026 14:54
Comment thread src/spikeinterface/postprocessing/tests/test_unit_locations.py Outdated
@alejoe91 alejoe91 merged commit 0f3cd0f into SpikeInterface:main May 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working postprocessing Related to postprocessing module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants