feat: custom deny aces count property#2779
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughTwo new Active Directory properties are introduced across all schema language bindings: ChangesCustom Deny ACE Count Properties
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds two new Active Directory node properties to the graph schema:
CustomExplicitDenyAcesCount/customexplicitdenyacescountCustomInheritedDenyAcesCount/custominheriteddenyacescountThe properties are registered in the AD CUE schema and exposed through the generated schema bindings for Go, C#, and TypeScript, including frontend display labels:
Custom Explicit Deny ACEs CountCustom Inherited Deny ACEs CountMotivation and Context
These properties allow AD nodes to represent counts of custom explicit and inherited deny ACEs in the schema so collectors, APIs, and UI consumers can reference them consistently by canonical property names.
This PR addresses: BED-8117
Related PRs:
SharpHoundCommon: SpecterOps/SharpHoundCommon#298
SharpHound: SpecterOps/SharpHound#218
SharpHoundEnterprise: https://github.com/SpecterOps/sharphound-enterprise/pull/113
How Has This Been Tested?
Tested locally.
Screenshots (optional):
Types of changes
Checklist:
Summary by CodeRabbit