Skip to content

CLP-1193 Split unified dogfooding in two steps for Jacoco - #338

Merged
BartLucien merged 3 commits into
masterfrom
lb/clp-906-split-dogfooding-and-iris
Oct 14, 2026
Merged

BartLucien merged 3 commits into
masterfrom
lb/clp-906-split-dogfooding-and-iris

Conversation

@BartLucien

@BartLucien BartLucien commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Part of CLP-906


Summary by Gitar

  • Split workflow:
    • Renamed the build job to build and moved IRIS analysis into a new run_iris job
    • Gated run_iris on a successful build result via if and needs
  • Concurrency:
    • Added workflow-level concurrency group that cancels in-progress runs per ref
    • Serialized IRIS runs with a single-slot iris concurrency group
  • Permissions:
    • Raised build job contents permission to write to fix CI
    • Limited run_iris job to contents: read with id-token: write

This will update automatically on new commits.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Split unified dogfooding in two steps for Jacoco CLP-1193 Split unified dogfooding in two steps for Jacoco Oct 13, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

CLP-1193

@BartLucien
BartLucien force-pushed the lb/clp-906-split-dogfooding-and-iris branch from 4660207 to 65d9446 Compare October 13, 2026 12:46
Comment thread .github/workflows/unified-dogfooding.yml
gitar-bot[bot]

This comment was marked as resolved.

@BartLucien
BartLucien force-pushed the lb/clp-906-split-dogfooding-and-iris branch from 65d9446 to ea81613 Compare October 13, 2026 13:00
@gitar-bot
gitar-bot Bot dismissed their stale review October 13, 2026 13:01

✅ All code review findings resolved.

Configure merge blocking

@GabrielFleischer GabrielFleischer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartLucien
BartLucien force-pushed the lb/clp-906-split-dogfooding-and-iris branch from 4a1218c to 0d9837c Compare October 14, 2026 09:46
@gitar-bot

gitar-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🔴 High risk · Granting the build job contents: write in .github/workflows/unified-dogfooding.yml could let compromised build steps modify repository contents.

Splits the unified dogfooding workflow into a build job and a separate run_iris job gated on build success, with concurrency groups and scoped permissions. The run_iris needs reference to the renamed job is fixed, and no open issues remain.

✅ 1 closed
✅ Bug: run_iris needs points to renamed job unified-platform-dogfooding

📄 .github/workflows/unified-dogfooding.yml:12 📄 .github/workflows/unified-dogfooding.yml:35-36
This PR renames the job unified-platform-dogfooding to build, but run_iris still has needs: [unified-platform-dogfooding]. GitHub rejects workflows whose needs names a job that doesn't exist, so the whole workflow fails validation. Neither the scheduled run nor a manual dispatch will run. Even if that were fixed some other way, the if: condition reads needs.build.result, and that only works when build is listed in needs. Change it to needs: [build].

Verification

Functional validation No results

Rules No rules evaluated

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@BartLucien
BartLucien merged commit 6a78b61 into master Oct 14, 2026
11 checks passed
@BartLucien
BartLucien deleted the lb/clp-906-split-dogfooding-and-iris branch October 14, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants