Skip to content

BUILD-10781 Migrate internal sub-action to Node 24, refresh stale pins - #21

Merged
jayadeep-km-sonarsource merged 1 commit into
masterfrom
feat/jkm/BUILD-10781-node24-deps
Jun 2, 2026
Merged

jayadeep-km-sonarsource merged 1 commit into
masterfrom
feat/jkm/BUILD-10781-node24-deps

Conversation

@jayadeep-km-sonarsource

@jayadeep-km-sonarsource jayadeep-km-sonarsource commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Why

GitHub deprecates Node 20 on Actions runners starting 2026-06-02. This repo has one direct Node 20 declaration and a few stale Sonar-wrapper pins:

  • .github/actions/with-post-step/action.yml declares using: node20. It's the internal helper that wraps main/post step semantics, called by the outer composite at action.yml. So every consumer of SonarSource/gh-action_setup-cloudflare-warp@v2 is indirectly executing Node 20 today.
  • SonarSource/vault-action-wrapper@3.1.0 (very stale; 3.5.0 is current and has Node 24 internals).
  • SonarSource/gh-action_pre-commit@1.1.0 (current is 1.2.0).
  • actions/checkout@v5.0.1, jdx/mise-action@v3.5.1 in test.yml / pre-commit.yml.

Linked ticket: BUILD-10781.

What changed

  • .github/actions/with-post-step/action.yml: using: node20 → using: node24.
  • SonarSource/vault-action-wrapper 3.1.0 → 3.5.0 (action.yml).
  • SonarSource/gh-action_pre-commit 1.1.0 → 1.2.0 (pre-commit.yml).
  • actions/checkout v5.0.1 → v6.0.2 (test.yml, pre-commit.yml).
  • jdx/mise-action v3.5.1 → v4.0.1 (test.yml, pre-commit.yml).

4 files, 5 insertions / 5 deletions.

Verification

  • pre-commit clean.
  • CI on this PR exercises test.yml against the actual Cloudflare WARP flow.

GitHub deprecates Node 20 on Actions runners starting 2026-06-02.

- .github/actions/with-post-step (internal helper used by the outer
  composite action) flipped from using: node20 -> using: node24.
- SonarSource/vault-action-wrapper 3.1.0 -> 3.5.0 (Node 24 internals).
- SonarSource/gh-action_pre-commit 1.1.0 -> 1.2.0.
- actions/checkout v5.0.1 -> v6.0.2, jdx/mise-action v3.5.1 -> v4.0.1
  in test/pre-commit workflows.
@gitar-bot

gitar-bot Bot commented Jun 2, 2026 •

Copy link
Copy Markdown
CI failed: The 'verify-sca' job failed because the repository lacks the necessary Vault credentials to authenticate with SonarQube. This appears to be a configuration issue in the infrastructure registration rather than a direct result of the PR changes.

Overview

The verify-sca CI job failed due to a Vault authentication error. This indicates that the repository is not correctly onboarded or authorized to access the required SonarQube credentials in HashiCorp Vault.

Failures

Vault Authentication Failure (confidence: high)

  • Type: configuration
  • Affected jobs: 79064067410
  • Related to change: no
  • Root cause: The Vault role github-sonarsource-gh-action_setup-cloudflare-warp does not exist or is not authorized, preventing the runner from retrieving SonarQube secrets.
  • Suggested fix: Ensure the repository is registered in the SonarSource infrastructure repository. Verify the Vault role naming convention matches the repository name and that the repository has been properly onboarded to the Vault service.

Summary

  • Change-related failures: 0. The failure is strictly related to repository infrastructure configuration.
  • Infrastructure/flaky failures: 1 (Vault authentication configuration issue).
  • Recommended action: Verify the repository's status in the central infrastructure (Terraform) repository and ensure the corresponding Vault role is provisioned for this repository.
Code Review ✅ Approved

Migrates internal sub-action to Node 24 and updates stale action dependencies to current versions. No issues found.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@jayadeep-km-sonarsource
jayadeep-km-sonarsource merged commit fe31a2b into master Jun 2, 2026
3 of 5 checks passed
@jayadeep-km-sonarsource
jayadeep-km-sonarsource deleted the feat/jkm/BUILD-10781-node24-deps branch June 2, 2026 11:55

This branch had an error being deployed

1 failed deployment
sca-checking — ece7148f Deployed Jun 2, 2026 by jayadeep-km-sonarsource via verify-sca #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants