Repository navigation
BUILD-10242: Add automatic post-action cleanup for WARP - #18
Merged
Merged
Conversation
jayadeep-km-sonarsource
marked this pull request as draft
January 28, 2026 07:56
jayadeep-km-sonarsource
changed the base branch from
master
to
feat/jd/BUILD-10242-refactor-prequisites
January 28, 2026 07:57
jayadeep-km-sonarsource
force-pushed
the
feat/jd/BUILD-10242-post-action
branch
3 times, most recently
from
January 28, 2026 08:28
06fa2c4 to
e17d34e
Compare
jayadeep-km-sonarsource
force-pushed
the
feat/jd/BUILD-10242-refactor-prequisites
branch
3 times, most recently
from
January 28, 2026 11:03
ea41b46 to
26e4ce2
Compare
Base automatically changed from
feat/jd/BUILD-10242-refactor-prequisites
to
master
January 28, 2026 11:07
jayadeep-km-sonarsource
force-pushed
the
feat/jd/BUILD-10242-post-action
branch
6 times, most recently
from
January 28, 2026 14:46
3e1840a to
1f07115
Compare
jayadeep-km-sonarsource
marked this pull request as ready for review
January 28, 2026 14:46
julien-carsique-sonarsource
approved these changes
Jan 28, 2026
Adds automatic cleanup of WARP connections after GitHub Actions jobs complete, preventing runners from remaining connected and avoiding resource leaks. Implementation: - Create with-post-step helper action using Node.js post-job lifecycle hooks - Add cleanup-warp.sh script to disconnect and delete WARP registration - Update action.yml to use helper action with automatic cleanup via branch reference - Add ShellSpec tests for cleanup script - Include 2-second delay before disconnect to ensure log flushing The helper action references feat/jd/BUILD-10242-post-action branch directly. After merge, this should be updated to reference the stable version branch. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jayadeep-km-sonarsource
force-pushed
the
feat/jd/BUILD-10242-post-action
branch
from
January 28, 2026 18:21
1f07115 to
e75f496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automatic cleanup of WARP connections after GitHub Actions jobs complete, preventing runners from remaining connected and avoiding resource leaks.
Changes
with-post-stephelper action using Node.js post-job lifecycle hooksNote
The helper action currently references the feature branch directly. I tried to use various options to use the local action directly, none of them seems to work with the post step. I have tried the approach that ci-github-actions took to refer
get-build-numberaction inconfig-mavenaction usingSet local action pathsstep, but it fails in the post action step.The helper action is unlikely to change as much. So i will just refer to
v2branch directly before merge.Test Plan
Tested on https://github.com/SonarSource/sonar-dummy/actions/runs/21437660464/job/61747687446