Skip to content

Update npm dependencies #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
Closed

Update npm dependencies #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"devDependencies": {
"@types/node": "^25.2.3",
"@vercel/ncc": "^0.38.3",
"@vercel/ncc": "^0.45.0",

@gitar-bot gitar-bot Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: package-lock.json not updated; still pins @vercel/ncc 0.38.4

The PR bumps @vercel/ncc to ^0.45.0 in package.json, but package-lock.json was not changed. Its root entry still declares "@vercel/ncc": "^0.38.3" (line 16) and node_modules/@vercel/ncc still resolves to 0.38.4 (lines 2241-2244). For 0.x versions a caret range only allows patch updates, so 0.38.4 does not satisfy ^0.45.0. That means npm ci will fail with a 'package.json and package-lock.json are not in sync' error, and npm install will quietly rewrite the lockfile. The committed ncc bundles (*/dist/index.js, which CLAUDE.md says must be rebuilt and committed) were also not rebuilt with the new ncc version, so the upgrade is never actually used. Fix: run npm install to regenerate package-lock.json, run npm run build, and commit both the lockfile and the rebuilt dist bundles.

Regenerate the lockfile and rebuild the bundles with ncc 0.45.0:

npm install && npm run build && git add package-lock.json */dist
  • Apply fix

Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎

"typescript": "^5.7.0",
"vitest": "^3.2.7"
},
Expand Down
Loading