Replace mypy with ty for static type checking#585
Open
svij-sc wants to merge 15 commits into
Open
Conversation
ty (from Astral, makers of ruff/uv) replaces mypy as the project's static type checker. Benchmark on this codebase (631 source files): | Metric | mypy | ty | Speedup | |-------------|----------|-------|---------| | Cold cache | 184.6s | 0.79s | ~234x | | Warm cache | 13.9s | 0.83s | ~17x | Changes: - Add ty to lint deps, remove mypy + mypy-extensions (keep mypy-protobuf for protoc stub generation) - Migrate mypy.ini config to [tool.ty.*] sections in pyproject.toml - Update Makefile type_check target: `uv run ty check` - Downgrade 12 rule categories to "warn" for initial migration; a follow-up PR will fix the 226 warnings and promote them back to errors - Update docs (CLAUDE.md, README.md, CHANGELOG.md, .claude/formatting.md) - Update .gitignore/.dockerignore cache directory references - Replace "mypy" mentions in source comments with generic "type checker" - Delete mypy.ini Co-Authored-By: shubhamvij <25601958+shubhamvij@users.noreply.github.com>
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
- Pin ty~=0.0.29 for reproducible builds - Add comment clarifying mypy-protobuf is for stub generation only - Exclude notebooks (*.ipynb) from type checking - Add comment about torch lacking inline types/stubs - Promote all ty rules back to default error severity (remove warn downgrades — fixes come in a follow-up PR) - Add [[tool.ty.overrides]] to suppress errors in generated *_pb2.py files that cannot be fixed Co-Authored-By: shubhamvij <25601958+shubhamvij@users.noreply.github.com>
Merged
svij-sc
commented
Apr 15, 2026
svij-sc
commented
Apr 17, 2026
Collaborator
Author
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
I updated the downstream PR where I addressed the ty fixes and to it added some new fixes identified by @kmontemayor2-sc below.
Ref: #586
Collaborator
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
I do feel pretty strongly about not type ignoring torch, WDYT about including #597 as part of the follow up here?
Otherwise this LGTM, thanks for the work :)
Co-authored-by: shubhamvij <25601958+shubhamvij@users.noreply.github.com> Co-authored-by: Kyle Montemayor <kmontemayor2@snapchat.com> Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com>
Collaborator
Author
I pulled in the changes - thanks @kmontemayor2-sc |
kmontemayor2-sc
approved these changes
May 14, 2026
Collaborator
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Awesome work Shubham! Really appreciate it :)
mkolodner-sc
approved these changes
May 14, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Stamped with a comment/question, thanks!
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty (from Astral, makers of ruff/uv) replaces mypy as the project's static type checker.
The ty fixes are introduced here: #586
Benchmarked on the code base (631 source files):
Changes:
uv run ty checkScope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: YES