fix(auth): using the wrong fallback auth-server#97
Open
Khaomi wants to merge 1 commit into
Open
Conversation
Member
|
I'd rather try to get upstreams to add auth provider to their API than do this, I'll leave this open in case they deny that change. |
Contributor
Author
|
Sounds good! |
|
What about adding an option to override the auth server for favorites? @DEATHB4DEFEAT |
|
It may take a long while for both upstreams to get So a workaround right now, while people are looking for multi-auth launchers to try, seems like a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth mode don't output list of auth urls anymore.
So instead of falling back to one singular auth url, we guess based on which hub the server listing is from, if it is from the old hub, then it probably use old auth, if it use the new hub, then it probably use new auth, if it use simplestation hub, then it probably use simplestation's auth.
Sample from Goobstation
