feat(images): map the large variant to real TMDB sizes - #16
Merged
Merged
Conversation
The server now sends a "large" variant hint between "featured" and "full". Unknown variants fell through to "original", so every large request fetched the full-size asset. Map it per role to the closest real TMDB rendition: posters w780, backdrops w1280, profiles h632, logos w500. TMDB serves no still size between w300 and original, so stills stay on original. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used all 5 included reviews currently available. Your 55 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Silo-Server/silo-server#742 adds client-selectable artwork sizes, and the server now sends a
"large"image-variant hint (~780px posters/stills, ~1280px backdrops/logos). This plugin'stmdbVariantSizefalls through tooriginalfor unknown variants — graceful, but it serves the heaviest possible asset for a hint that asked for a mid tier.Approach
Add a
case "large"mapping each role to the closest real TMDB size: poster →w780, backdrop →w1280, profile →h632, logo →w500(largest sized rendition TMDB offers), still →original(TMDB has nothing between w300 and original; anything smaller would make large smaller than featured). The default →originalfallback is untouched. Vocabulary and degradation rules are now documented in the SDK (Silo-Server/silo-plugin-sdk feat/image-variant-large PR).Verification
go build ./...,go test ./...,make build,make testall pass; five newTestResolveImageURLlarge cases (one per role).Related issue: N/A — plugin half of Silo-Server/silo-server#742.
AI-use disclosure
Implemented by Claude Code (maintainer-directed) with human review.
🤖 Generated with Claude Code