log node/edge/property count when loading proto CPGs#1815
Merged
Conversation
mpollmeier
requested changes
May 7, 2025
Contributor
mpollmeier
left a comment
mpollmeier
left a comment
There was a problem hiding this comment.
joernio/flatgraph#320 (review) applies here as well
flatgraph can log more cheaply log this info internally while loading a graph. ODB graphs are converted on the fly to flatgraph, so that'll happen for those graphs as well. Add this for protos, and all formats are covered.
maltek
changed the title
Contributor
Author
|
I've added logging of counts during deserialization over in the other PR, so this PR now only logs counts for proto CPGs (the only CPGs not going through that code path) |
mpollmeier
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.