Skip to content

Modernize SoftRas for CUDA/PyTorch compatibility#112

Open
ChloeMowanDAI wants to merge 10 commits into
ShichenLiu:masterfrom
ChloeMowanDAI:master
Open

Modernize SoftRas for CUDA/PyTorch compatibility#112
ChloeMowanDAI wants to merge 10 commits into
ShichenLiu:masterfrom
ChloeMowanDAI:master

Conversation

@ChloeMowanDAI

Copy link
Copy Markdown

No description provided.

Comment thread MODIFIED_FILES.txt Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe exclude this file from the PR?

Comment thread README.md

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes to this file?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whole .idea folder should be removed?

@ChloeMowanDAI ChloeMowanDAI left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ur right, I thought .idea was already in .gitignore, but I forgot to double check...

@ShichenLiu

Copy link
Copy Markdown
Owner

Thanks for the update, but I think now you accidentally deleted the readme, other than that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants