Simplify Phase 2 HLT workflows#257
Open
VourMa wants to merge 2 commits into
Open
Conversation
slava77
reviewed
Jun 5, 2026
Comment on lines
+2083
to
+2085
| upgradeWFs['L1NGTScoutingWithNano'].step2['--datatier'] = 'GEN-SIM-DIGI-RAW,NANOAODSIM' | ||
| upgradeWFs['L1NGTScoutingWithNano'].step2['--procModifiers'] = 'ngtScouting,nano_l1_hlt' | ||
| upgradeWFs['L1NGTScoutingWithNano'].step2['--eventcontent'] = 'FEVTDEBUGHLT,NANOAODSIM' |
There was a problem hiding this comment.
[for the full PR: I like the changes; Thank you.]
Here and in a few more cases, should these be more like this:
Suggested change
| upgradeWFs['L1NGTScoutingWithNano'].step2['--datatier'] = 'GEN-SIM-DIGI-RAW,NANOAODSIM' | |
| upgradeWFs['L1NGTScoutingWithNano'].step2['--procModifiers'] = 'ngtScouting,nano_l1_hlt' | |
| upgradeWFs['L1NGTScoutingWithNano'].step2['--eventcontent'] = 'FEVTDEBUGHLT,NANOAODSIM' | |
| upgradeWFs['L1NGTScoutingWithNano'].step2['--datatier'] += ',GEN-SIM-DIGI-RAW' | |
| upgradeWFs['L1NGTScoutingWithNano'].step2['--procModifiers'] += ',nano_l1_hlt' | |
| upgradeWFs['L1NGTScoutingWithNano'].step2['--eventcontent'] += ',FEVTDEBUGHLT' |
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's a further simplification. I applied this here and in a couple more cases. If it looks good, I can push it to the central cms-sw repo.
slava77
approved these changes
Jun 8, 2026
slava77
left a comment
slava77
left a comment
There was a problem hiding this comment.
Looks fine to me.
I don't think our CI can test anything here, so let's go upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not too relevant for our tracking work but something that @slava77 had asked in passing:
@syntax@slava77 let me know if you want to check it and/or if you see more room for improvement, otherwise I will submit it to CMSSW over the weekend.