Skip to content

Ten upstream OCCT PRs now sit on a pre-8.0.1 base, and patch 0020 was never filed at all #657

Description

@gsdali

Fallout from the OCCT 8.0.1 absorb (#654). Housekeeping, deliberately not done as part of that
change so each PR update stays reviewable on its own.

The ten open PRs need rebasing

V8_0_1 absorbed ten of our carried patches, which means every OCCT PR still open was authored
against a base that has now moved. Verified open as of 2026-08-03:

Our patch Upstream PR Fixes
0010 OCCT#1386 Intf_Interference O(1) tangent zone + breaker (#319)
0011 OCCT#1388 XCAFDoc_ShapeTool::OwnAutoNamingScope (#341/#363)
0012 OCCT#1390 GetApplication / CDF_Directory races (#344)
0014 OCCT#1394 PCDM driver reentrancy (#349)
0015 OCCT#1397 CDM_Application metadata table (#353)
0016 OCCT#1399 Resource_Manager / Storage_Schema (#374)
0017 OCCT#1410 Null ReShape context (#484)
0018 OCCT#1417 GCPnts count contract (#555)
0019 OCCT#1418 AdvApp2Var Jacobi workspace slot (#522)
0021 OCCT#1420 CPnts adaptive arc-length integration (#603)

All eleven surviving patches apply cleanly to V8_0_1 with zero file-level collisions against
the 74 files 8.0.1 touched, so a rebase should be mechanical. That is not the same as the PRs being
mergeable: GitHub compares against master, which has moved further than the tag.

Two are worth a closer look than a plain rebase:

Patch 0020 has no upstream filing

0020-BRepFeat_MakeCylindricalHole-select-tool-parts-532 fixes a silent wrong answer:
BRepFeat_NoError with no material removed whenever the drill crosses two bodies or severs one
(#532). Scripts/patches/README.md and okf/references/carried-occt-patches.md both record it as
"not yet filed". It is the only carried patch with no upstream PR, so it is the only one that can
never retire.

The reproducer and before/after measurements already exist at
Scripts/repro/532-cylindrical-hole-part-selection/. Per upstream's guidance on
OCCT#1409 it should
go straight to a PR with no companion repro issue.

Note the writeup also records a second defect in the same heuristic that we did not fix:
PerformThruNext's closest-interval fallback nests its // parbar > Last branch inside
if (parbar < First), making that case unreachable as written. Worth deciding whether it rides
along or stays reported-only.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cluster:kernelOCCTSwift core geometry/meshing/IO librariesphase:occt-801OCCT 8.0.1 absorb and follow-through (#654)priority:P2Normalrelease:v2.0.0Tracked in the v2.0.0 release (#669)type:choreMaintenance / tooling

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions