You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fallout from the OCCT 8.0.1 absorb (#654). Housekeeping, deliberately not done as part of that
change so each PR update stays reviewable on its own.
The ten open PRs need rebasing
V8_0_1 absorbed ten of our carried patches, which means every OCCT PR still open was authored
against a base that has now moved. Verified open as of 2026-08-03:
All eleven surviving patches apply cleanly to V8_0_1 with zero file-level collisions against
the 74 files 8.0.1 touched, so a rebase should be mechanical. That is not the same as the PRs being
mergeable: GitHub compares against master, which has moved further than the tag.
0020-BRepFeat_MakeCylindricalHole-select-tool-parts-532 fixes a silent wrong answer: BRepFeat_NoError with no material removed whenever the drill crosses two bodies or severs one
(#532). Scripts/patches/README.md and okf/references/carried-occt-patches.md both record it as
"not yet filed". It is the only carried patch with no upstream PR, so it is the only one that can
never retire.
The reproducer and before/after measurements already exist at Scripts/repro/532-cylindrical-hole-part-selection/. Per upstream's guidance on OCCT#1409 it should
go straight to a PR with no companion repro issue.
Note the writeup also records a second defect in the same heuristic that we did not fix: PerformThruNext's closest-interval fallback nests its // parbar > Last branch inside if (parbar < First), making that case unreachable as written. Worth deciding whether it rides
along or stays reported-only.
Fallout from the OCCT 8.0.1 absorb (#654). Housekeeping, deliberately not done as part of that
change so each PR update stays reviewable on its own.
The ten open PRs need rebasing
V8_0_1absorbed ten of our carried patches, which means every OCCT PR still open was authoredagainst a base that has now moved. Verified open as of 2026-08-03:
0010001100120014001500160017001800190021All eleven surviving patches apply cleanly to
V8_0_1with zero file-level collisions againstthe 74 files 8.0.1 touched, so a rebase should be mechanical. That is not the same as the PRs being
mergeable: GitHub compares against
master, which has moved further than the tag.Two are worth a closer look than a plain rebase:
0016/ OCCT#1399 still carries the mutex version of theStorage_Schemahalf. Revisit #374's Storage_Schema::ICurrentData fix: per-instance field instead of a mutex (upstream review, OCCT#1399) #518 recordsthat maintainer review asked for the per-instance field instead, and our patch was redesigned;
the PR was never updated to match.
0017/ OCCT#1410 is inShapeFix, the area 8.0.1 changed most heavily (fix(kernel): make TopoDS_TShape::myState atomic (Issue #1154) #1323, chore(#819): extend derive-swift-file-split.py to any file, reassess #687's four #1377, Split the remaining .mm bridge implementation files by OCCT subsystem (#396 follow-on) #1380,test: share the bsplineSurface(interiorMultiplicityU:) continuity fixture (#1253) #1331, Spike: gate the Scripts/patches/ count and the gate-scripts step count against their own stated prose (recurred at v2.0.0-kernel.1-3, #1032, #1157/#1402, and still-open #1066) #1408 all landed there). Re-verify the defect still reproduces on
masterbefore pushing.Patch 0020 has no upstream filing
0020-BRepFeat_MakeCylindricalHole-select-tool-parts-532fixes a silent wrong answer:BRepFeat_NoErrorwith no material removed whenever the drill crosses two bodies or severs one(#532).
Scripts/patches/README.mdandokf/references/carried-occt-patches.mdboth record it as"not yet filed". It is the only carried patch with no upstream PR, so it is the only one that can
never retire.
The reproducer and before/after measurements already exist at
Scripts/repro/532-cylindrical-hole-part-selection/. Per upstream's guidance onOCCT#1409 it should
go straight to a PR with no companion repro issue.
Note the writeup also records a second defect in the same heuristic that we did not fix:
PerformThruNext's closest-interval fallback nests its// parbar > Lastbranch insideif (parbar < First), making that case unreachable as written. Worth deciding whether it ridesalong or stays reported-only.