Add *IntInv interpolations to SCT extension - #564
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the SparseConnectivityTracer integration for DataInterpolations.jl by adding tracer-aware overloads for the integral-inverse interpolation types, so Jacobian/Hessian sparsity detection can work with these interpolations.
Changes:
- Import
ConstantInterpolationIntInvandLinearInterpolationIntInvinto the SCT extension module. - Register SCT overloads for
ConstantInterpolationIntInvandLinearInterpolationIntInvwith appropriate derivative-structure flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| (:ConstantInterpolationIntInv, false, true), | ||
| (:LinearInterpolationIntInv, false, false), |
There was a problem hiding this comment.
Fixed in the latest commit — updated the comment to include ConstantInterpolationIntInv alongside ConstantInterpolation and LinearInterpolation as the exceptions with a (piecewise) zero second derivative.
| (:ConstantInterpolationIntInv, false, true), | ||
| (:LinearInterpolationIntInv, false, false), |
There was a problem hiding this comment.
Added tests for ConstantInterpolationIntInv and LinearInterpolationIntInv in test/Extensions/sparseconnectivitytracer_tests.jl. The new "Integral Inverse Interpolations" testset uses strictly-positive u data and covers Jacobian/Hessian sparsity and output-shape checks for both types (commit: Add SCT tests for ConstantInterpolationIntInv and LinearInterpolationIntInv).
SciML/DataInterpolations.jl#564 Needed for all-the-states.
SciML/DataInterpolations.jl#564 Needed for all-the-states.
The prior commit correctly removed accidental [deps] entries from PR SciML#564, but also dropped them from weakdeps/extras, breaking Pkg validation. Restore those sections while leaving Test out of runtime deps. Co-authored-by: Cursor <cursoragent@cursor.com>
* qa: extend ExplicitImports ignore list and drop unused deps * Keep Test and SparseConnectivityTracer in extras/weakdeps only The prior commit correctly removed accidental [deps] entries from PR #564, but also dropped them from weakdeps/extras, breaking Pkg validation. Restore those sections while leaving Test out of runtime deps. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.