Use Kokkos::Parallel in Solver Utils#270
Conversation
|
@EmilyBourne Can you make "ExactSolution" callable on GPU? Then all Kokkos Loops should be finished. |
Ah, I had hoped to avoid this 😅 I will open a PR to remove the inheritance from |
I have put this in draft temporarily until this is fixed |
Actually we can avoid removing the inheritance. We just need to put either a void calculate_error(Vector<double> error, ConstVector<T> r, ConstVector<T> theta, ConstVector<T> exact_solution) const;method in void exact_solution(ConstVector<T> r, ConstVector<T> theta, Vector<T> exact) const;@AbdelhadiKara will take care of this |
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):