Sites: Stop zone soft lock when a player 'steals' site objects.

[dijksterhuis]

Some newer players think it's a good idea to steal PAVN mortars/zpus etc and take them back to their FOB.

Repurposing enemy assets is a legit strategy, but it causes a zone to become soft locked as the site will not complete unless the objects are destroyed (not alive).

---

There's also a case where loading the mortar/zpu into a vehicle with advanced logistics will cause a soft lock. This change also solves that case -- don't allow critical site objects to be loaded into vehicles.

I can't quite remember what happens if the player dies within the search radius while the object is still attached to their character model via advanced logistics. My intuition tells me it would not being a good thing.

I can include some of the logic from #178 to cover that additional case.

[dijksterhuis]

i can extract the logic for this out to a separate script and call that function 3x. would be a cleaner approach as it's basically the code in 3x files atm.

[veteran29]

It would be way faster to execute inAreaArray once, it also accepts an object as a centre pos, which I understand the _siteStore is (not familiar with MF internals).

Below code should be faster on average:

Suggested change

	private _pos = getPos _siteStore;
	private _objects = _siteStore getVariable ["aaGuns", []];
	/*
	Teardown when all guns are either
	- destroyed
	- no longer with 20m radius of site centre point
	*/
	private _objectsAreAliveInRadius = _objects findIf {
	(alive _x) && (count ([_x] inAreaArray [_pos, 20, 20, 0, false]) > 0)
	};
	_objectsAreAliveInRadius == -1
	/*
	Teardown when all guns are either
	- destroyed
	- no longer with 20m radius of site centre point
	*/
	((_siteStore getVariable "aaGuns") inAreaArray [_siteStore, 20, 20, 0, false]) findIf {alive _x} == -1

[dijksterhuis]

Aye i see what you're saying, will do.

[dijksterhuis]

@veteran29

• Extracted logic out to new script as per my comment Sites: Stop zone soft lock when a player 'steals' site objects. #180 (comment)
• Switched the ordering around for the 1x inAreaArray execution

---

I was working on an additional check for when players have loaded the site object into a vehicle with the Advanced Logistics module, as that can causes site/zone soft-locks too -- see: cd97f17

But there's at least three downstream edge cases to take into account, beyond the teardown condition check

• do not delete object when player is carrying object (object deletion in front of player)
• do not delete object when in a vehicle logistics inventory (object will no longer exist in logistics inventory)
• do not delete object if ever has been in a vehicle logistics inventory (object deletion in front of player)

Simplest / cleanest option seems to be to just to disable the ability to load these objects into vehicles, so that's the latest version.