Conversation
SF-Zhou
commented
Jul 16, 2026
Owner
- Add benches/bench_compare.rs with four groups at 1/4/8 threads: concurrent get (all hits), mixed 90% get / 10% insert, hot-key exclusive entry access (lockmap vs dashmap), and LRU mixed workload under eviction pressure (LruLockMap vs moka)
- Normalize semantics across crates and document fairness notes in the file header (guard-based get copies the value out; moka excluded from the entry group, dashmap from the eviction group)
- Add dashmap 6 and moka 0.12 as dev-dependencies only
- README: add a Benchmarks section with qualitative guidance; no absolute numbers published (to be measured on dedicated hardware)
- Add benches/bench_compare.rs with four groups at 1/4/8 threads: concurrent get (all hits), mixed 90% get / 10% insert, hot-key exclusive entry access (lockmap vs dashmap), and LRU mixed workload under eviction pressure (LruLockMap vs moka) - Normalize semantics across crates and document fairness notes in the file header (guard-based get copies the value out; moka excluded from the entry group, dashmap from the eviction group) - Add dashmap 6 and moka 0.12 as dev-dependencies only - README: add a Benchmarks section with qualitative guidance; no absolute numbers published (to be measured on dedicated hardware)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Criterion benchmark suite to compare lockmap performance against popular alternatives (dashmap and moka), and documents how to run/interpret these benchmarks.
Changes:
- Introduce
benches/bench_compare.rswith multiple multi-threaded workload groups and explicit “fairness notes” to align differing crate semantics. - Add
dashmapandmokaas dev-dependencies and register a newbench_comparebenchmark target. - Document benchmark usage and guidance in
README.md, and note the addition inCHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds a Benchmarks section with run commands and interpretation guidance. |
| CHANGELOG.md | Notes the addition of the comparison benchmark suite. |
| Cargo.toml | Adds dashmap and moka as dev-dependencies and registers the bench_compare bench target. |
| benches/bench_compare.rs | Implements the new comparison benchmark suite with normalized semantics across crates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 3 3
Lines 2272 2272
=======================================
Hits 2256 2256
Misses 16 16 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.