Skip to content

Fix CMake config for gmsh and adios2 dependencies#205

Open
Sichao25 wants to merge 8 commits into
SCOREC:masterfrom
Sichao25:yus/export
Open

Fix CMake config for gmsh and adios2 dependencies#205
Sichao25 wants to merge 8 commits into
SCOREC:masterfrom
Sichao25:yus/export

Conversation

@Sichao25

@Sichao25 Sichao25 commented Feb 6, 2026

Copy link
Copy Markdown

Fixes CMake configuration issues when omega_h is used as a dependency with gmsh and adios2 enabled. Downstream projects were unable to find the CMake config files for these dependencies.
Changes includes:

  • Link adios2 as a dependency and enable C language support
  • Include FindGmsh.cmake to properly expose gmsh to downstream projects
  • Add a new test to install omega_h as a dependency

Comment thread cmake/bob.cmake
@Sichao25 Sichao25 marked this pull request as ready for review February 21, 2026 00:49

@cwsmith cwsmith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments.

Comment thread example/external_installation/CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
@jacobmerson

Copy link
Copy Markdown
Collaborator

/runtests

1 similar comment
@cwsmith

cwsmith commented Jun 10, 2026

Copy link
Copy Markdown

/runtests

@github-actions

Copy link
Copy Markdown

Test Results:

  • Kokkos CUDA: skipped
  • No Kokkos: skipped
  • Kokkos Serial: skipped
  • Kokkos OpenMP: skipped
  • Kokkos CUDA Warnings as Errors: skipped
  • Kokkos CUDA Python: skipped

(details)

@github-actions

Copy link
Copy Markdown

Test Results:

  • Kokkos CUDA: failure
  • No Kokkos: skipped
  • Kokkos Serial: skipped
  • Kokkos OpenMP: skipped
  • Kokkos CUDA Warnings as Errors: skipped
  • Kokkos CUDA Python: skipped

(details)

@github-actions

Copy link
Copy Markdown

Test Results:

  • Kokkos CUDA: success
  • No Kokkos: success
  • Kokkos Serial: success
  • Kokkos OpenMP: success
  • Kokkos CUDA Warnings as Errors: success
  • Kokkos CUDA Python: success

(details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants