Remove bits features#1766
Merged
Merged
Conversation
tarcieri
force-pushed
the
remove-bits-features
branch
2 times, most recently
from
450a7fb to
ae36abc
Compare
Upstream support was removed in RustCrypto/traits#2417. See also: zkcrypto/ff#157
tarcieri
force-pushed
the
remove-bits-features
branch
from
ae36abc to
e4e1295
Compare
Contributor
|
Ugh. I really hope releases don't get cut with this. I need I do see an RFC was made, it just means that |
kayabaNerve
added a commit
to kayabaNerve/trout
that referenced
this pull request
Jun 6, 2026
This allows us to remove our shim for `rand_core`. Additionally, the `ciphersuite` (unused), `multiexp`, and `dkg` crates from Serai have been dropped as they're on the old versions of `ff`, `group`. From `multiexp`, I've copied a function which simply does the sum as-is, with no actual speedup. For `dkg`, we only used `Participant`, which I've simply copied in. Unfortunately, we need `PrimeFieldBits` for any intelligent multi-exponentation and to convert to a consistent representation of bytes when converting to scalars over the class group. [`k256` removed support for `PrimeFieldBits`]( RustCrypto/elliptic-curves#1766 ) so our own shim has been added there as well...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream support was removed in RustCrypto/traits#2417.
See also: zkcrypto/ff#157