Repository navigation
codex window ids, rubric mark, live menu, honest chart - #36
Open
DexterStorey wants to merge 3 commits into
Open
DexterStorey wants to merge 3 commits into
DexterStorey wants to merge 3 commits into
Conversation
|
try this branch: |
|
@greptileai review |
1 similar comment
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from using the app.
Codex windows are named by their length, not their slot. Codex reports windows as
primary/secondary, and the slot doesn't mean a length: a Pro account's only window, 7 days, isprimary, and so is a Plus account's 5-hour window. Both the usage probe and the response headers now name each window<feature>:<minutes>m(codex:300m,codex:10080m), so every account's 7-day window is the same window. That fixes "Show the 7d limit" appearing twice in settings, in both the app and the terminal dashboard. It also stops hiding the 7-day limit from silently hiding another account's 5-hour one, since hidden windows are stored by id. I checked this read-only against two real accounts: Plus givescodex:300m, codex:10080mand Pro givescodex:10080m. Any previously hidden codex window shows again once, because its old id no longer matches.The menu bar:
set_text/set_icon). It's rebuilt only when its structure changes, such as an account being added or removed or two accounts swapping order.The throughput chart is drawn by the app. GPUI Kit's
AreaChartprinted the hover value as a raw float (977834521) titled with the axis label, hardcoded dashed gridlines, and had no y-axis values. Its spline and the old 48-point peak resampling also drew plateaus, slopes across empty time, and a dip below zero. The new chart:Verified: 155 TypeScript tests on Bun 1.2.20 and 1.4.2, and 13 Rust tests, including new ones for the menu's patch-or-rebuild rule and the probe's window id. The menu bar mark and pressure dots were rendered and checked by eye.