Update filter condition in data processing pipeline - #106
Open
mar-baute wants to merge 1 commit into
Open
Conversation
On the current version of the Wikipedia page, the header row is no longer removed by this filter. html_table() returns the column titles as the first data row, and the exact string it produces has changed since this was written, so the != comparison no longer matches. The header row survives distinct() and reaches separate(), where it has no four-digit year — producing an NA row and a warning, and inflating the counts downstream. Rather than update the hardcoded string, this changes the filter to keep only rows containing a four-digit year, which is what separate() requires anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the current version of the Wikipedia page, the header row is no longer removed by this filter. html_table() returns the column titles as the first data row, and the exact string it produces has changed since this was written, so the != comparison no longer matches. The header row survives distinct() and reaches separate(), where it has no four-digit year — producing an NA row and a warning, and inflating the counts downstream.
Rather than update the hardcoded string, this changes the filter to keep only rows containing a four-digit year, which is what separate() requires anyway.