Updated TBB version to 2022.3#586
Conversation
There was a problem hiding this comment.
Pull request overview
Updates tutorial/build configuration to use oneTBB 2022.3.0 as the default/newest TBB version.
Changes:
- Bump referenced oneTBB version in tutorial documentation to 2022.3.0.
- Add a new CMake preset (
tbb2022_3_0) and make it thetbb_NEWESTdefault. - Update release presets to inherit the new TBB preset.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tutorials/README.md.in | Updates Windows/Linux tutorial download links to oneTBB 2022.3.0. |
| tutorials/README.md | Updates Windows/Linux tutorial download links to oneTBB 2022.3.0 (but contains an inconsistent Linux URL). |
| scripts/cmake-presets/tbb.json | Adds tbb2022_3_0 preset and points tbb_NEWEST to it. |
| scripts/cmake-presets/release.json | Switches release presets to inherit tbb2022_3_0. |
| scripts/cmake-presets/os.json | Adds env var for EMBREE_TBB_2022_3_0_DIR (but path points to 2021.12.0). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| Now download and unpack some recent TBB version for Windows, e.g. oneTBB 2022.3.0: | ||
|
|
||
| https://github.com/oneapi-src/oneTBB/releases/download/v2021.2.0/oneapi-tbb-2021.2.0-win.zip | ||
| https://github.com/oneapi-src/oneTBB/releases/download/v2022.3.0/oneapi-tbb-2022.3.0-win.zip |
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Updated the CMake TBB_DIR examples in tutorials/README.md (both Windows and Linux sections) to reference oneapi-tbb-2022.3.0 instead of oneapi-tbb-2021.2.0. Committed in fd2c9b0.
There was a problem hiding this comment.
Updated in 8d038cc: both Windows and Linux -D TBB_DIR=... examples now use oneapi-tbb-2022.3.0 for consistency.
| Now download and unpack some recent TBB version for Windows, e.g. oneTBB 2022.3.0: | ||
|
|
||
| https://github.com/oneapi-src/oneTBB/releases/download/v2021.2.0/oneapi-tbb-2021.2.0-win.zip | ||
| https://github.com/oneapi-src/oneTBB/releases/download/v2022.3.0/oneapi-tbb-2022.3.0-win.zip |
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Updated the CMake TBB_DIR examples in tutorials/README.md.in (both Windows and Linux sections) to reference oneapi-tbb-2022.3.0 instead of oneapi-tbb-2021.2.0. Committed in fd2c9b0.
There was a problem hiding this comment.
Updated in 8d038cc: both Windows and Linux -D TBB_DIR=... examples now use oneapi-tbb-2022.3.0 so the template stays consistent.
|
I am confused, we do not use cmake_presets anymore, looks like this is a very old pull request that needs to be updated. |
svenwoop
left a comment
svenwoop
left a comment
There was a problem hiding this comment.
We do not use cmake-presets anymore, this pull request needs updates.
Agent-Logs-Url: https://github.com/RenderKit/embree/sessions/b1282a1f-ad86-4c40-a406-bc46f86ceed5 Co-authored-by: stefanatwork <93931354+stefanatwork@users.noreply.github.com>
Handled in 8d038cc by reverting the cmake-presets changes from this PR so it no longer updates those preset files.
Addressed in 8d038cc by removing the cmake-presets updates from this PR. |
No description provided.