fix: add HandleNull to HeartbeatConverter - #372
Merged
Conversation
fakejutsu
changed the title
Member
|
You have some failing tests to review, but the fundamental idea looks fine. |
Nihlus
added
gateway
fakejutsu
marked this pull request as draft
August 29, 2026 07:21
fakejutsu
marked this pull request as ready for review
August 29, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Text.Json skips custom converters for null reference values unless HandleNull is enabled, causing the gateway heartbeat null payload to deserialize to a null IHeartbeat instead of Heartbeat(null)