Skip to content

*tgex2: loosen swap acceptance threshold to fix false rejections #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jschueller wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −16
Open

*tgex2: loosen swap acceptance threshold to fix false rejections #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions SRC/ctgex2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ SUBROUTINE CTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
COMPLEX CZERO, CONE
PARAMETER ( CZERO = ( 0.0E+0, 0.0E+0 ),
$ CONE = ( 1.0E+0, 0.0E+0 ) )
REAL TWENTY
PARAMETER ( TWENTY = 2.0E+1 )
REAL HUNDRED
PARAMETER ( HUNDRED = 1.0E+2 )
INTEGER LDST
PARAMETER ( LDST = 2 )
LOGICAL WANDS
Expand Down Expand Up @@ -273,9 +273,11 @@ SUBROUTINE CTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* on 04/01/10.
* "Bug" reported by Ondra Kamenik, confirmed by Julie Langou, fixed by
* Jim Demmel and Guillaume Revy. See forum post 1783.
* Then from TWENTY to HUNDRED on 03/20/26.
* "Bug" reported by Heiko Weichelt and Bobby Cheng from MathWorks.
*
THRESHA = MAX( TWENTY*EPS*SA, SMLNUM )
THRESHB = MAX( TWENTY*EPS*SB, SMLNUM )
THRESHA = MAX( HUNDRED*EPS*SA, SMLNUM )
THRESHB = MAX( HUNDRED*EPS*SB, SMLNUM )
*
* Compute unitary QL and RQ that swap 1-by-1 and 1-by-1 blocks
* using Givens rotations and perform the swap tentatively.
Expand Down
10 changes: 6 additions & 4 deletions SRC/dtgex2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ SUBROUTINE DTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* .. Parameters ..
DOUBLE PRECISION ZERO, ONE
PARAMETER ( ZERO = 0.0D+0, ONE = 1.0D+0 )
DOUBLE PRECISION TWENTY
PARAMETER ( TWENTY = 2.0D+01 )
DOUBLE PRECISION HUNDRED
PARAMETER ( HUNDRED = 1.0D+02 )
INTEGER LDST
PARAMETER ( LDST = 4 )
LOGICAL WANDS
Expand Down Expand Up @@ -322,9 +322,11 @@ SUBROUTINE DTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* on 04/01/10.
* "Bug" reported by Ondra Kamenik, confirmed by Julie Langou, fixed by
* Jim Demmel and Guillaume Revy. See forum post 1783.
* Then from TWENTY to HUNDRED on 03/20/26.
* "Bug" reported by Heiko Weichelt and Bobby Cheng from MathWorks.
*
THRESHA = MAX( TWENTY*EPS*DNORMA, SMLNUM )
THRESHB = MAX( TWENTY*EPS*DNORMB, SMLNUM )
THRESHA = MAX( HUNDRED*EPS*DNORMA, SMLNUM )
THRESHB = MAX( HUNDRED*EPS*DNORMB, SMLNUM )
*
IF( M.EQ.2 ) THEN
*
Expand Down
10 changes: 6 additions & 4 deletions SRC/stgex2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ SUBROUTINE STGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* .. Parameters ..
REAL ZERO, ONE
PARAMETER ( ZERO = 0.0E+0, ONE = 1.0E+0 )
REAL TWENTY
PARAMETER ( TWENTY = 2.0E+01 )
REAL HUNDRED
PARAMETER ( HUNDRED = 1.0E+02 )
INTEGER LDST
PARAMETER ( LDST = 4 )
LOGICAL WANDS
Expand Down Expand Up @@ -323,9 +323,11 @@ SUBROUTINE STGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* on 04/01/10.
* "Bug" reported by Ondra Kamenik, confirmed by Julie Langou, fixed by
* Jim Demmel and Guillaume Revy. See forum post 1783.
* Then from TWENTY to HUNDRED on 03/20/26.
* "Bug" reported by Heiko Weichelt and Bobby Cheng from MathWorks.
*
THRESHA = MAX( TWENTY*EPS*DNORMA, SMLNUM )
THRESHB = MAX( TWENTY*EPS*DNORMB, SMLNUM )
THRESHA = MAX( HUNDRED*EPS*DNORMA, SMLNUM )
THRESHB = MAX( HUNDRED*EPS*DNORMB, SMLNUM )
*
IF( M.EQ.2 ) THEN
*
Expand Down
10 changes: 6 additions & 4 deletions SRC/ztgex2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ SUBROUTINE ZTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
COMPLEX*16 CZERO, CONE
PARAMETER ( CZERO = ( 0.0D+0, 0.0D+0 ),
$ CONE = ( 1.0D+0, 0.0D+0 ) )
DOUBLE PRECISION TWENTY
PARAMETER ( TWENTY = 2.0D+1 )
DOUBLE PRECISION HUNDRED
PARAMETER ( HUNDRED = 1.0D+2 )
INTEGER LDST
PARAMETER ( LDST = 2 )
LOGICAL WANDS
Expand Down Expand Up @@ -273,9 +273,11 @@ SUBROUTINE ZTGEX2( WANTQ, WANTZ, N, A, LDA, B, LDB, Q, LDQ, Z,
* on 04/01/10.
* "Bug" reported by Ondra Kamenik, confirmed by Julie Langou, fixed by
* Jim Demmel and Guillaume Revy. See forum post 1783.
* Then from TWENTY to HUNDRED on 03/20/26.
* "Bug" reported by Heiko Weichelt and Bobby Cheng from MathWorks.
*
THRESHA = MAX( TWENTY*EPS*SA, SMLNUM )
THRESHB = MAX( TWENTY*EPS*SB, SMLNUM )
THRESHA = MAX( HUNDRED*EPS*SA, SMLNUM )
THRESHB = MAX( HUNDRED*EPS*SB, SMLNUM )
*
* Compute unitary QL and RQ that swap 1-by-1 and 1-by-1 blocks
* using Givens rotations and perform the swap tentatively.
Expand Down
Loading