Repository navigation
Conversation
* Card ID: RHEL-306441 Reuse the existing ID validator before probing systemd or loading collector configuration. Add regression coverage for both commands.
Peto-RH
force-pushed
the
pschrimp/collector-validates-id
branch
from
November 20, 2026 15:22
8bc4bf6 to
2deace0
Compare
| // and loads the collector configuration before connecting for timer operations. | ||
| // Returns the systemd connection, the collector config, and any validation errors. | ||
| func ValidateCollectorAndConnect(collectorID string) (*systemd.Conn, Config, error) { | ||
| validatedID, err := ValidateID(collectorID) |
Contributor
There was a problem hiding this comment.
I see there are a few functions that are initially running this same validation call. I wonder if we can move the ValidateID call into GetConfig so we don't have to have this as a requirement for each. and encapsulate this validation in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the existing ID validator before probing systemd or loading collector configuration. Add regression coverage for both commands.