Repository navigation
Conversation
Pull in the revision providing the combined package-profile APIs (SendPackageProfile, ProfileNotSupportedError); no rhc code uses them yet. Adapt RefreshContent to the API changes of the newer revision: UpdateEntitlementCertificate now returns the certificate and key paths, and signals an up-to-date (304) certificate with a typed error instead of nil, which must not surface as a failure. The new transitive pure-Go SQLite driver (go-rpmdb -> github.com/glebarez/go-sqlite) ends up in the vendor tree and breaks the Fedora RPM build; the next commit fixes that. Assisted-by: GLM 5.3 Signed-off-by: Jason Jerome <jajerome@redhat.com>
The rhsm2 bump pulled in github.com/glebarez/go-sqlite (the pure-Go SQLite driver used by go-rpmdb), which breaks the Fedora RPM build in two ways: * The driver's sources carry a '// import "modernc.org/sqlite"' vanity import comment. Module mode ignores it, but Fedora's %gobuild runs in GOPATH mode (GO111MODULE=off), which enforces the declared import path and fails on the mismatch with the directory. Strip the comment with a patch applied to the vendored sources in %prep, so it covers vendor tarballs regardless of how they were generated. * The driver ships SQLITE-LICENSE, the SQLite public-domain dedication. askalono cannot map it to an SPDX identifier, which fails %go_vendor_license_check even though the computed expression matches the spec's License tag. Exclude the file from the licensing calculation: it is a grant, not a license of the compiled code, which is covered by the detected BSD-3-Clause license files. Verified by running the rpmbuild workflow steps in a fedora:latest container: the build, the license check and the unit tests all pass with both changes in place. Assisted-by: GLM 5.3 Signed-off-by: Jason Jerome <jajerome@redhat.com>
Contributor
|
I have probably better solution here: jirihnidek/rhsm2#118 |
Contributor
|
And one more PR for |
Contributor
Author
|
I've closed this branch as it served only to experiment with different approaches to manage a new dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.