Skip to content

ci(security): fix zizmor findings in GitHub Actions workflows - #633

Merged
Archana-PandeyM merged 1 commit into
mainfrom
arpandey/fixZizmorFindings
Nov 5, 2026
Merged

Archana-PandeyM merged 1 commit into
mainfrom
arpandey/fixZizmorFindings

Conversation

@Archana-PandeyM

Copy link
Copy Markdown
Collaborator

Resolve all zizmor findings reported at informational severity so the security scan in .github/workflows/security.yml passes, and raise the job's --min-severity from high to informational accordingly.

  • Pin all action references to full commit SHAs with version comments (unpinned-uses)
  • Pass action inputs and step outputs to run: scripts via env vars instead of direct template expansion (template-injection)
  • Set persist-credentials: false on checkouts that don't need git credentials (artipacked)
  • Add a 7-day cooldown to all Dependabot update entries (dependabot-cooldown)
  • Use GitHub's $/... self-repository syntax for local composite actions and the reusable rpmbuild workflow (self-repository)
  • Document inline zizmor ignores for intentionally floating images: Fedora latest/rawhide containers and Candlepin test services (unpinned-images)

@Archana-PandeyM
Archana-PandeyM force-pushed the arpandey/fixZizmorFindings branch from 36f4b6d to 4e697d6 Compare November 4, 2026 14:15
@Archana-PandeyM
Archana-PandeyM force-pushed the arpandey/fixZizmorFindings branch from 4e697d6 to a2bdba4 Compare November 5, 2026 07:52
@Archana-PandeyM
Archana-PandeyM marked this pull request as ready for review November 5, 2026 07:53
@Archana-PandeyM
Archana-PandeyM requested a review from a team as a code owner November 5, 2026 07:53

@mjcr99 mjcr99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Archana-PandeyM! I've got a couple of suggestions.

Comment thread .github/workflows/go.yml Resolved
Comment thread .github/workflows/security.yml Resolved
Resolve all zizmor findings reported at informational severity so the
security scan in .github/workflows/security.yml passes, and raise the
job's --min-severity from high to informational accordingly.

- Pin all action references to full commit SHAs with version comments
  (unpinned-uses)
- Pass action inputs and step outputs to run: scripts via env vars
  instead of direct template expansion (template-injection)
- Set persist-credentials: false on checkouts that don't need git
  credentials (artipacked)
- Add a 7-day cooldown to all Dependabot update entries
  (dependabot-cooldown)
- Use GitHub's $/... self-repository syntax for local composite actions
  and the reusable rpmbuild workflow (self-repository)
- Document inline zizmor ignores for intentionally floating images:
  Fedora latest/rawhide containers and Candlepin test services
  (unpinned-images)

* Card ID: CCT-3131

Signed-off-by: Archana Pandey <arpandey@redhat.com>
@Archana-PandeyM
Archana-PandeyM force-pushed the arpandey/fixZizmorFindings branch from a2bdba4 to 8ea56e4 Compare November 5, 2026 08:44
Comment thread .github/workflows/integration-tests.yml Resolved

@mjcr99 mjcr99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Archana-PandeyM!

@Archana-PandeyM
Archana-PandeyM merged commit ded4c8e into main Nov 5, 2026
29 checks passed
@Archana-PandeyM
Archana-PandeyM deleted the arpandey/fixZizmorFindings branch November 5, 2026 10:55
Archana-PandeyM added a commit that referenced this pull request Nov 5, 2026
Resolve all zizmor findings reported at informational severity on the
release-0.2 branch so the security scan in .github/workflows/security.yml
passes, and raise the job's --min-severity from high to informational
accordingly. Mirrors the fix merged to main via #633, using the same
pinned SHAs.

* Pin all action references to full commit SHAs with version comments
  (unpinned-uses)
* Set persist-credentials: false on checkouts that don't need git
  credentials (artipacked)
* Add a 7-day cooldown to all Dependabot update entries
  (dependabot-cooldown)

* Card ID: CCT-3131

Signed-off-by: Archana Pandey <arpandey@redhat.com>
Archana-PandeyM added a commit that referenced this pull request Nov 5, 2026
Resolve all zizmor findings reported at informational severity on the
release-0.2 branch so the security scan in .github/workflows/security.yml
passes, and raise the job's --min-severity from high to informational
accordingly. Mirrors the fix merged to main via #633, using the same
pinned SHAs.

* Pin all action references to full commit SHAs with version comments
  (unpinned-uses)
* Set persist-credentials: false on checkouts that don't need git
  credentials (artipacked)
* Add a 7-day cooldown to all Dependabot update entries
  (dependabot-cooldown)

* Card ID: CCT-3131

Signed-off-by: Archana Pandey <arpandey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants