Repository navigation
ci(security): fix zizmor findings in GitHub Actions workflows - #633
Merged
Merged
Conversation
Archana-PandeyM
force-pushed
the
arpandey/fixZizmorFindings
branch
from
November 4, 2026 14:15
36f4b6d to
4e697d6
Compare
Archana-PandeyM
force-pushed
the
arpandey/fixZizmorFindings
branch
from
November 5, 2026 07:52
4e697d6 to
a2bdba4
Compare
Archana-PandeyM
marked this pull request as ready for review
November 5, 2026 07:53
mjcr99
reviewed
Nov 5, 2026
mjcr99
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Archana-PandeyM! I've got a couple of suggestions.
Resolve all zizmor findings reported at informational severity so the security scan in .github/workflows/security.yml passes, and raise the job's --min-severity from high to informational accordingly. - Pin all action references to full commit SHAs with version comments (unpinned-uses) - Pass action inputs and step outputs to run: scripts via env vars instead of direct template expansion (template-injection) - Set persist-credentials: false on checkouts that don't need git credentials (artipacked) - Add a 7-day cooldown to all Dependabot update entries (dependabot-cooldown) - Use GitHub's $/... self-repository syntax for local composite actions and the reusable rpmbuild workflow (self-repository) - Document inline zizmor ignores for intentionally floating images: Fedora latest/rawhide containers and Candlepin test services (unpinned-images) * Card ID: CCT-3131 Signed-off-by: Archana Pandey <arpandey@redhat.com>
Archana-PandeyM
force-pushed
the
arpandey/fixZizmorFindings
branch
from
November 5, 2026 08:44
a2bdba4 to
8ea56e4
Compare
mjcr99
approved these changes
Nov 5, 2026
mjcr99
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @Archana-PandeyM!
stephenbourke
approved these changes
Nov 5, 2026
Archana-PandeyM
added a commit
that referenced
this pull request
Nov 5, 2026
Resolve all zizmor findings reported at informational severity on the release-0.2 branch so the security scan in .github/workflows/security.yml passes, and raise the job's --min-severity from high to informational accordingly. Mirrors the fix merged to main via #633, using the same pinned SHAs. * Pin all action references to full commit SHAs with version comments (unpinned-uses) * Set persist-credentials: false on checkouts that don't need git credentials (artipacked) * Add a 7-day cooldown to all Dependabot update entries (dependabot-cooldown) * Card ID: CCT-3131 Signed-off-by: Archana Pandey <arpandey@redhat.com>
Archana-PandeyM
added a commit
that referenced
this pull request
Nov 5, 2026
Resolve all zizmor findings reported at informational severity on the release-0.2 branch so the security scan in .github/workflows/security.yml passes, and raise the job's --min-severity from high to informational accordingly. Mirrors the fix merged to main via #633, using the same pinned SHAs. * Pin all action references to full commit SHAs with version comments (unpinned-uses) * Set persist-credentials: false on checkouts that don't need git credentials (artipacked) * Add a 7-day cooldown to all Dependabot update entries (dependabot-cooldown) * Card ID: CCT-3131 Signed-off-by: Archana Pandey <arpandey@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all zizmor findings reported at informational severity so the security scan in .github/workflows/security.yml passes, and raise the job's --min-severity from high to informational accordingly.