Repository navigation
feat(test): consolidate RHC SELinux AVC checks - #615
Merged
Merged
Conversation
mjcr99
marked this pull request as ready for review
October 22, 2026 07:13
stephenbourke
self-requested a review
October 22, 2026 09:33
Contributor
There was a problem hiding this comment.
Thanks @mjcr99! Looks good.
Just have one comment and a general note we might want to consider later.
With the use of AVC checker across each test, there is an added 1 second sleep added due to _flush_audit_events(). I guess it's just a consequence of using the plugin as is. There might be a more efficient way write this function.
https://github.com/RedHatInsights/pytest-client-tools/blob/main/pytest_client_tools/plugin.py#L397
mjcr99
force-pushed
the
macano/consolidate-avc-checker
branch
2 times, most recently
from
October 26, 2026 16:09
b113eb8 to
7fed320
Compare
Contributor
Author
|
Failed proxy tests are unrelated and tracked under CCT-3095. |
Use pytest-client-tools as the single AVC collector for RHC integration tests. Move known RHC AVC exceptions into the project skip-list module, remove the duplicate checker and report hook, and document the shared path. Assisted-by: GPT-6 Luna Signed-off-by: mjcr99 <macano@redhat.com>
mjcr99
force-pushed
the
macano/consolidate-avc-checker
branch
from
November 3, 2026 13:26
7fed320 to
d250f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use pytest-client-tools as the single AVC collector for RHC integration tests. Move known RHC AVC exceptions into the project skip-list module, remove the duplicate checker and report hook, and document the shared path.
Assisted-by: GPT-6 Luna