Skip to content

feat(test): consolidate RHC SELinux AVC checks - #615

Merged
mjcr99 merged 1 commit into
mainfrom
macano/consolidate-avc-checker
Nov 3, 2026
Merged

mjcr99 merged 1 commit into
mainfrom
macano/consolidate-avc-checker

Conversation

@mjcr99

@mjcr99 mjcr99 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Description

Use pytest-client-tools as the single AVC collector for RHC integration tests. Move known RHC AVC exceptions into the project skip-list module, remove the duplicate checker and report hook, and document the shared path.

Assisted-by: GPT-6 Luna

@mjcr99
mjcr99 marked this pull request as ready for review October 22, 2026 07:13
@mjcr99
mjcr99 requested a review from a team as a code owner October 22, 2026 07:13
@stephenbourke
stephenbourke self-requested a review October 22, 2026 09:33

@stephenbourke stephenbourke left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjcr99! Looks good.

Just have one comment and a general note we might want to consider later.

With the use of AVC checker across each test, there is an added 1 second sleep added due to _flush_audit_events(). I guess it's just a consequence of using the plugin as is. There might be a more efficient way write this function.

https://github.com/RedHatInsights/pytest-client-tools/blob/main/pytest_client_tools/plugin.py#L397

Comment thread TESTING.md Resolved
@mjcr99
mjcr99 force-pushed the macano/consolidate-avc-checker branch 2 times, most recently from b113eb8 to 7fed320 Compare October 26, 2026 16:09
@mjcr99

mjcr99 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Failed proxy tests are unrelated and tracked under CCT-3095.

@mjcr99
mjcr99 requested a review from stephenbourke October 27, 2026 08:24
Use pytest-client-tools as the single AVC collector for RHC integration
tests. Move known RHC AVC exceptions into the project skip-list module,
remove the duplicate checker and report hook, and document the shared path.

Assisted-by: GPT-6 Luna
Signed-off-by: mjcr99 <macano@redhat.com>
@mjcr99
mjcr99 force-pushed the macano/consolidate-avc-checker branch from 7fed320 to d250f24 Compare November 3, 2026 13:26

@Archana-PandeyM Archana-PandeyM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjcr99
mjcr99 merged commit b9ffffa into main Nov 3, 2026
29 of 30 checks passed
@mjcr99
mjcr99 deleted the macano/consolidate-avc-checker branch November 3, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants