add SetRootWeights proxy - #3132
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny (account under 90 days with 0 public repos), tempered by repository write access, substantive merged history, matching commit authorship, and no Gittensor association; add-set-root-weights-proxy → main. The change adds a fresh, stable wire index and restricts the new proxy type to FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the static diff review. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN Gittensor association; account is under 90 days old, but repository write access and substantial merged contribution history support correctness-focused scrutiny. PR body was empty/trivial; the Auditor has auto-filled it. Please review. The new proxy receives fresh SCALE index Duplicate work: This PR is the better candidate. Recommend closing #3129. Unlike #3129, it avoids silently reactivating existing
FindingsNo findings. ConclusionThe implementation safely introduces the narrowly scoped proxy without changing legacy proxy authority, and its tests and documentation are appropriately updated. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Operators need to delegate root-basket curation without granting a broader proxy scope. Reusing the deprecated
RootWeightsvariant could unexpectedly reactivate existing delegations, so this change introduces a new proxy type with a fresh wire index.Changes
SetRootWeightsas proxy type index18while leaving deprecatedRootWeightsat index12deny-all.SetRootWeightstoSubtensorModule::set_root_weights.set_root_weightsinto a dedicated call group included by the same broad filters.Behavioral and upgrade impact
This is a runtime-facing proxy enum and filter change and therefore takes effect with a runtime upgrade. It requires no storage migration. Existing
RootWeightsproxies remain deprecated and deny all calls; users must explicitly create or update a proxy usingSetRootWeights.Validation
SetRootWeightsallowlist.git diff --checkpasses.uv.