Skip to content

parameters mistake#12

Open
ybbz wants to merge 1 commit intoREMitchell:masterfrom
ybbz:master
Open

parameters mistake#12
ybbz wants to merge 1 commit intoREMitchell:masterfrom
ybbz:master

Conversation

@ybbz
Copy link
Copy Markdown

@ybbz ybbz commented Apr 2, 2016

  1. def getInternalLinks(bsObj, includeUrl) has two parameters, but getInternalLinks(startingPage) has only one parameter and parameter type is not anastomotic. So we should change it to getInternalLinks(bsObj, “”).
  2. We should judge the length of internalLinks with len(internalLinks).
  3. We don’t have a function named getNextExternalLink, I think getNextExternalLink should change to getRandomExternalLink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant