feat: Add strict typing to a lot of packages#720
Open
Quenty wants to merge 101 commits into
Open
Conversation
Add explicit type annotations and `: ()` return types and resolve all strict errors. Inline the EnabledMixin surface since the old solver cannot intersect it, and fix a latent ActiveAction.Value comparison that prevented deactivation cleanup.
Add explicit type annotations and `: ()` return types to MarketplaceServiceCache and resolve all strict errors.
Add explicit type annotations and `: ()` return types to OverriddenProperty and resolve all strict errors.
Add explicit type annotations and `: ()` return types and resolve all strict errors. Add the @quenty/rx dependency required for Observable typing.
Add explicit type annotations and `: ()` return types to RadialImage and resolve all strict errors.
Add explicit type annotations and `: ()` return types across the snackbar service, story, and option utils, and resolve all strict errors.
Add explicit type annotations and `: ()` return types to the Time library and resolve all strict errors.
Record the explicit `: ()` no-return annotation convention, the EnabledMixin/invariant-generic old-solver workarounds, and a warning that omitting --defs=globalTypes.d.lua produces false unknown-global errors on tick/time.
…fixes, selene _self/shadowing) + add selene dimension to eval scorer
…ast Tie :Implement receiver
…minal analyze errors
…hrough selfAny (any) to kill nominal flake
…uau-lsp V1 symlink-nominal flake, unreproducible locally)
…ict escape from PR #720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.