Repository navigation
Remove the closure boxes - #172
Merged
Merged
Conversation
…harmonic balance HarmonicBalance.jl#539 and #540 are merged and their branch is gone. With #540 the first-order Krylov flow equals the harmonic-balance flow for the same ansatz, so the commensurate comparison is no longer broken.
The solutions handed to the threaded zero check, the masked branches of get_branches and the solution index of get_single_solution and get_variable_solutions were reassigned after a closure captured them. The index conversion is shared as solution_position.
oameye
force-pushed
the
fix/closure-boxes
branch
from
October 19, 2026 08:58
c82883e to
6f8a235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also carries the last commit of #171, which landed after its squash-merge: the test environment takes HarmonicBalance from
master(itsrefactor/harmonic-kindbranch is gone since HarmonicBalance.jl#539 and #540 merged), and the commensurate Krylov vs harmonic balance comparison intest/steady_states/krylov.jlis no longer marked broken, since with HarmonicBalance.jl#540 the two first-order flows are equal.The closure-box scan of JuliaLang/julia#60478 finds four
Core.Boxcaptures in HarmonicSteadyState: in_get_raw_solution(threaded zero check),get_branches,get_single_solutionandget_variable_solutions. Each captured variable was reassigned after capture. They are now assigned once; the index conversion thatget_single_solutionandget_variable_solutionsduplicated is shared assolution_position.After this and HarmonicBalance.jl#540, the scan reports no boxes in QuestBase, HarmonicSteadyState or HarmonicBalance (HarmonicBalance.jl#482).