Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Indicators/SuperTrend.cs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ public override void Reset()
_averageTrueRange.Reset();
_previousTrailingLowerBand = 0;
_previousTrailingUpperBand = 0;
_previousClose = 0;
_prevSuper = -1;
base.Reset();
}
Expand Down
30 changes: 30 additions & 0 deletions Tests/Indicators/SuperTrendTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/

using System;
using System.Collections.Generic;
using NUnit.Framework;
using QuantConnect.Data.Market;
using QuantConnect.Indicators;
Expand Down Expand Up @@ -62,6 +63,35 @@ public void Getters()
Assert.AreNotEqual(0, STR.CurrentTrailingLowerBand);
}

[Test]
public void ProducesTheSameValuesAfterReset()
{
// a one period average true range is ready on the first update, so the trailing band
// comparison reads the previous close before any bar has assigned it
var superTrend = new SuperTrend(1, 3);
var reference = new DateTime(2024, 1, 1);
var bars = new[]
{
new TradeBar(reference, Symbols.SPY, 10m, 11m, 9m, 10.5m, 0, Time.OneDay),
new TradeBar(reference.AddDays(1), Symbols.SPY, 10.5m, 12m, 10m, 11.5m, 0, Time.OneDay)
};

var expected = new List<decimal>();
foreach (var bar in bars)
{
superTrend.Update(bar);
expected.Add(superTrend.Current.Value);
}

superTrend.Reset();

for (var i = 0; i < bars.Length; i++)
{
superTrend.Update(bars[i]);
Assert.AreEqual(expected[i], superTrend.Current.Value);
}
}

[Test]
public override void ResetsProperly()
{
Expand Down
Loading